Recipe: Play and Pause video#2469
Merged
Merged
Conversation
googlebot
added
the
cla: yes
brianegan
force-pushed
the
video-player-recipe
branch
from
e14fb87 to
45509fc
Compare
brianegan
force-pushed
the
video-player-recipe
branch
from
45509fc to
bd13f24
Compare
sfshaza2
approved these changes
Mar 5, 2019
sfshaza2
left a comment
sfshaza2
left a comment
Contributor
There was a problem hiding this comment.
I see some minor things editorial things that I'm not going to worry about for now, like an overuse of "will". ;) LGTM
Contributor
Author
Haha, noooooooo! I'll submit a PR tomorrow AM fixing those up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a recipe demonstrating how to play and pause video using the video_player plugin!
Note: This recipe builds on the Camera recipe and that code should be ignored (had to do this because this recipe depends on the
plugindirectory existing).I have a couple more recipes ready to go that also add to the plugin directory, but want to hold off on submitting all of them at once so we can review them one at a time!